kfaraz commented on code in PR #18709: URL: https://github.com/apache/druid/pull/18709#discussion_r2488519907
########## server/src/main/java/org/apache/druid/server/metrics/DataSourceTaskIdHolder.java: ########## @@ -46,11 +48,13 @@ public class DataSourceTaskIdHolder @Inject(optional = true) BroadcastDatasourceLoadingSpec broadcastDatasourceLoadingSpec = BroadcastDatasourceLoadingSpec.ALL; + @Nullable Review Comment: Yeah, given that we have embedded tests now, it should be easy to fix as we can iterate much faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
