GWphua commented on PR #18731: URL: https://github.com/apache/druid/pull/18731#issuecomment-3580587732
Hi @aho135, since the scope of adding `GroupByQueryMetrics` is out of this PR, I have created #18781 to allow us to further discuss it there. > I have a first draft on this: https://github.com/aho135/druid/commit/9f8209149221be0ff6714dc4faa1c10e6e92274e > Lmk if you have any thoughts on this. Thanks! I have a draft for `GroupByQueryMetrics` before creating this PR, and my draft is a direct extension of your implementation shared. I think I will try and create a PR with that draft soon. I was actually hoping to get this PR merged, before sharing the draft, because that draft is done as a follow-up to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
