aho135 commented on PR #18731:
URL: https://github.com/apache/druid/pull/18731#issuecomment-3572882100

   Thanks for adding those max metrics @GWphua!
   
   What do you think about adding `sqlQueryId` as a dimension only for the MAX 
metrics? I think this would be useful for understanding how much the query 
execution time was affected by the mergeBufferAcquisition. Can also do this in 
a follow-up PR if you think it's useful. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to