GWphua commented on code in PR #18731:
URL: https://github.com/apache/druid/pull/18731#discussion_r2548293283
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupByStatsProvider.java:
##########
@@ -120,6 +143,7 @@ public void addQueryStats(PerQueryStats perQueryStats)
if (perQueryStats.getMergeBufferAcquisitionTimeNs() > 0) {
mergeBufferQueries++;
mergeBufferAcquisitionTimeNs +=
perQueryStats.getMergeBufferAcquisitionTimeNs();
+ mergeBufferTotalUsage += perQueryStats.getMergeBufferTotalUsage();
Review Comment:
I was thinking about this.
There are other metrics where taking MAX will also make sense --
spilledBytes --> How much storage would be good to configure?
dictionarySize --> How large can the merge dictionary size get?
I am considering adding another metric (maxSpilledBytes, maxDictionarySize,
maxSpilledBytes). What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
