aho135 commented on code in PR #18731:
URL: https://github.com/apache/druid/pull/18731#discussion_r2543534386
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupByStatsProvider.java:
##########
@@ -120,6 +143,7 @@ public void addQueryStats(PerQueryStats perQueryStats)
if (perQueryStats.getMergeBufferAcquisitionTimeNs() > 0) {
mergeBufferQueries++;
mergeBufferAcquisitionTimeNs +=
perQueryStats.getMergeBufferAcquisitionTimeNs();
+ mergeBufferTotalUsage += perQueryStats.getMergeBufferTotalUsage();
Review Comment:
@GWphua Instead of summing here, what do you think about taking the max?
Then the metric emitted would be the max merge buffer usage of a single query
in that emission period. This would be a good signal for operators on whether
they need to tweak the mergeBuffer size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
