aho135 commented on code in PR #18731:
URL: https://github.com/apache/druid/pull/18731#discussion_r2550616770
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupByStatsProvider.java:
##########
@@ -120,6 +143,7 @@ public void addQueryStats(PerQueryStats perQueryStats)
if (perQueryStats.getMergeBufferAcquisitionTimeNs() > 0) {
mergeBufferQueries++;
mergeBufferAcquisitionTimeNs +=
perQueryStats.getMergeBufferAcquisitionTimeNs();
+ mergeBufferTotalUsage += perQueryStats.getMergeBufferTotalUsage();
Review Comment:
Yeah agreed. I do think it makes sense to have it for those 3 metrics
Even for `mergeBuffer/acquisitionTimeNs` I think there's value in having the
max, as it gives operators a signal on whether to increase numMergeBuffers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
