Fly-Style commented on code in PR #19700:
URL: https://github.com/apache/druid/pull/19700#discussion_r3604495597
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorSpec.java:
##########
@@ -148,4 +148,12 @@ default boolean requireRestart(SupervisorSpec proposedSpec)
{
return true;
}
+
+ /**
+ * Returns true if the supervisor restart should cause task disruption,
false otherwise
+ */
+ default boolean shouldRestartCauseTaskDisruption()
Review Comment:
done
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java:
##########
@@ -650,7 +654,11 @@ public boolean isAnotherTaskGroupPublishingToPartitions(
* @return reference to existing supervisor, if exists and was stopped, null
if there was no supervisor with this id
*/
@Nullable
- private SupervisorSpec possiblyStopAndRemoveSupervisorInternal(String id,
boolean writeTombstone)
+ private SupervisorSpec possiblyStopAndRemoveSupervisorInternal(
+ String id,
+ boolean writeTombstone,
+ boolean shouldRestartCauseTaskDisruption
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
