kfaraz commented on code in PR #19700:
URL: https://github.com/apache/druid/pull/19700#discussion_r3613186398
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorSpec.java:
##########
@@ -148,4 +148,14 @@ default boolean requireRestart(SupervisorSpec proposedSpec)
{
return true;
}
+
+ /**
+ * Returns true if replacing this (running) spec with {@code proposedSpec}
should roll over (stop and
+ * republish) the currently running tasks, false if the existing tasks
should be left running as-is.
+ * Invoked on the running spec; default is conservative (always roll over).
+ */
+ default boolean shouldRolloverTasksOnRestart(SupervisorSpec proposedSpec)
+ {
Review Comment:
@Fly-Style , thinking some more on this, let's change the existing method
`requireRestart` instead of adding a new method.
ref: https://github.com/apache/druid/pull/19700#issuecomment-5004535735
Let's try to merge it off soon so that we can ensure it is include it in
Druid 38 to avoid multiple changes to this interface since it an extension API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
