Fly-Style commented on code in PR #19700:
URL: https://github.com/apache/druid/pull/19700#discussion_r3612758217
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java:
##########
@@ -663,7 +673,7 @@ private SupervisorSpec
possiblyStopAndRemoveSupervisorInternal(String id, boolea
new NoopSupervisorSpec(null, pair.rhs.getDataSources())
); // where NoopSupervisorSpec is a tombstone
}
- pair.lhs.stop(true);
+ pair.lhs.stop(terminateTasks);
Review Comment:
It is not false anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
