kfaraz commented on code in PR #19700:
URL: https://github.com/apache/druid/pull/19700#discussion_r3613998212
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorSpecUpdateResult.java:
##########
@@ -25,17 +25,17 @@
public final class SupervisorSpecUpdateResult
{
private final boolean modified;
- private final boolean restarted;
+ private final SupervisorSpecUpdateAction action;
Review Comment:
Nit: I wonder if this field will also get serialized out even though it
doesn't have a getter.
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java:
##########
@@ -663,7 +673,7 @@ private SupervisorSpec
possiblyStopAndRemoveSupervisorInternal(String id, boolea
new NoopSupervisorSpec(null, pair.rhs.getDataSources())
); // where NoopSupervisorSpec is a tombstone
}
- pair.lhs.stop(true);
+ pair.lhs.stop(terminateTasks);
Review Comment:
@Fly-Style , this seems like a valid point. I think we will now start
calling this API with a `false` and there may be a race condition where the
auto-scaler does end up doing a scaling, even though we wanted to restart the
supervisor only.
But that said, I think it is fine since we don't want to stop the
auto-scaler decisions anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
