FrankChen021 commented on code in PR #19700:
URL: https://github.com/apache/druid/pull/19700#discussion_r3607330403
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java:
##########
@@ -663,7 +673,7 @@ private SupervisorSpec
possiblyStopAndRemoveSupervisorInternal(String id, boolea
new NoopSupervisorSpec(null, pair.rhs.getDataSources())
); // where NoopSupervisorSpec is a tombstone
}
- pair.lhs.stop(true);
+ pair.lhs.stop(terminateTasks);
Review Comment:
[P2] Stop the autoscaler before a non-disruptive restart
When `terminateTasks` is false, the old autoscaler remains active throughout
`pair.lhs.stop(false)`. Its allocation executor can enqueue a
`DynamicAllocationTasksNotice` ahead of the `ShutdownNotice`; that handler does
not reject the `STOPPING` state and invokes `gracefulShutdownInternal()`,
rolling over the tasks despite the spec explicitly opting out. Stop/remove the
autoscaler before stopping the supervisor, or make allocation notices ignore
`STOPPING`, to preserve the non-disruption guarantee.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
