clintropolis commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r294543665
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/granularity/AllGranularity.java
##########
@@ -62,6 +62,15 @@ public DateTime toDate(String filePath, Formatter formatter)
throw new UnsupportedOperationException("This method should not be invoked
for this granularity type");
}
+ /**
+ * All granularity matches no interval.
+ */
+ @Override
+ public boolean match(Interval interval)
Review comment:
It makes sense after reviewing how this is used, but could you elaborate in
the javadoc a bit more on why all matches to no interval and none matches to
any interval?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
