clintropolis commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r294573070
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/BaseAppenderatorDriver.java
##########
@@ -271,7 +271,7 @@ SegmentsOfInterval get(long timestamp)
* @return currently persisted commit metadata
*/
@Nullable
- public abstract Object startJob();
+ public abstract Object startJob(StreamAppenderatorDriverSegmentLockHelper
lockHelper);
Review comment:
nit: seems strange to me that `StreamAppenderatorDriverSegmentLockHelper` is
being used by `BaseAppenderatorDriver` which `StreamAppenderatorDriver`
extends, maybe the lock helper class should be renamed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
