clintropolis commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r294553352
##########
File path:
core/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java
##########
@@ -307,20 +315,18 @@ public boolean isEmpty()
);
}
- public Set<TimelineObjectHolder<VersionType, ObjectType>> findOvershadowed()
+ public Set<TimelineObjectHolder<VersionType, ObjectType>>
findFullyOvershadowed()
{
+ lock.readLock().lock();
Review comment:
I think all of these methods should probably be calling `readLock().lock()`
outside of the `try/finally` like you have done here, would you consider making
them all consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
