leventov commented on a change in pull request #8089: add
CachingClusteredClient benchmark, refactor some stuff
URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304941924
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategy.java
##########
@@ -79,19 +79,19 @@
* {@link GroupByQueryQueryToolChest} to delegate implementation to the
strategy
*/
@Nullable
- default CombiningFunction<Row> createMergeFn(Query<Row> query)
+ default BinaryOperator<Row> createMergeFn(Query<Row> query)
{
- throw new UOE("%s doesn't support merge function",
this.getClass().getName());
+ throw new UOE("%s doesn't provide a merge function",
this.getClass().getName());
}
/**
- * See {@link
org.apache.druid.query.QueryToolChest#createOrderingFn(Query)}, allows
+ * See {@link
org.apache.druid.query.QueryToolChest#createComparator(Query)}, allows
* {@link GroupByQueryQueryToolChest} to delegate implementation to the
strategy
*/
@Nullable
- default Ordering<Row> createOrderingFn(Query<Row> queryParam)
+ default Comparator<Row> createComparator(Query<Row> queryParam)
Review comment:
I think `createResultComparator` would be a clearer name for this method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
