leventov commented on a change in pull request #8089: add
CachingClusteredClient benchmark, refactor some stuff
URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304455734
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategy.java
##########
@@ -69,6 +74,26 @@
Sequence<Row> mergeResults(QueryRunner<Row> baseRunner, GroupByQuery query,
Map<String, Object> responseContext);
+ /**
+ * See {@link org.apache.druid.query.QueryToolChest#createMergeFn(Query)}
for details, allows
+ * {@link GroupByQueryQueryToolChest} to delegate implementation to the
strategy
+ */
+ @Nullable
+ default CombiningFunction<Row> createMergeFn(Query<Row> query)
+ {
+ throw new UOE("%s doesn't support merge function",
this.getClass().getName());
+ }
+
+ /**
+ * See {@link
org.apache.druid.query.QueryToolChest#createOrderingFn(Query)}, allows
+ * {@link GroupByQueryQueryToolChest} to delegate implementation to the
strategy
+ */
+ @Nullable
+ default Ordering<Row> createOrderingFn(Query<Row> queryParam)
+ {
+ throw new UOE("%s doesn't support merge function",
this.getClass().getName());
Review comment:
"ordering function"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
