leventov commented on a change in pull request #8089: add
CachingClusteredClient benchmark, refactor some stuff
URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304843219
##########
File path: processing/src/main/java/org/apache/druid/query/QueryToolChest.java
##########
@@ -91,24 +91,24 @@ public final JavaType getBySegmentResultType()
*/
public QueryRunner<ResultType> mergeResults(QueryRunner<ResultType> runner)
{
- return new ResultMergeQueryRunner<>(runner, this::createOrderingFn,
this::createMergeFn);
+ return new ResultMergeQueryRunner<>(runner, this::createComparator,
this::createMergeFn);
}
/**
* Creates a merge function that is used to merge intermediate aggregates
from historicals in broker. This merge
* function is used in the default {@link ResultMergeQueryRunner} provided by
* {@link QueryToolChest#mergeResults(QueryRunner)} and can be used in
additional future merge implementations
*/
- public CombiningFunction<ResultType> createMergeFn(Query<ResultType> query)
+ public BinaryOperator<ResultType> createMergeFn(Query<ResultType> query)
{
throw new UOE("%s doesn't support merge function",
query.getClass().getName());
}
/**
- * Creates an ordering comparator that is used to order results. This
ordering function is used in the defaul
+ * Creates an ordering comparator that is used to order results. This
comparator is used in the defaul
* {@link ResultMergeQueryRunner} provided by {@link
QueryToolChest#mergeResults(QueryRunner)}
*/
- public Ordering<ResultType> createOrderingFn(Query<ResultType> query)
+ public Comparator<ResultType> createComparator(Query<ResultType> query)
Review comment:
Optional: maybe call it `createResultComparator`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
