leventov commented on a change in pull request #8089: add
CachingClusteredClient benchmark, refactor some stuff
URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304842281
##########
File path: core/src/main/java/org/apache/druid/common/guava/GuavaUtils.java
##########
@@ -62,4 +63,18 @@ public static Long tryParseLong(@Nullable String string)
return null;
}
+
+ /**
+ * If first argument is not null, return it, else return the other argument.
Sort of like
+ * {@link com.google.common.base.Objects#firstNonNull(Object, Object)}
except will not explode if both arguments are
+ * null.
+ */
+ @Nullable
+ public static <T> T firstNonNull(T arg1, T arg2)
Review comment:
Please annotate both parameters `@Nullable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
