jon-wei opened a new pull request #9373: Fix join filter push down post-join virtual column handling URL: https://github.com/apache/druid/pull/9373 This PR fixes an issue in JoinFilterAnalyzer where post-join virtual columns were incorrectly identified as belonging to the base table column set, leading to filters on such virtual columns being pushed down incorrectly. The PR fixes the issue by passing in the set of base table columns (including any pre-join virtual columns) to JoinFilterAnalyzer.splitFilter instead of checking prefixes. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
