jon-wei commented on a change in pull request #9373: Fix join filter push down
post-join virtual column handling
URL: https://github.com/apache/druid/pull/9373#discussion_r381552442
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
##########
@@ -297,6 +302,22 @@ public boolean isEnableFilterPushDown()
return enableFilterPushDown;
}
+ @VisibleForTesting
Review comment:
I collapsed this into a shared method with the block in makeCursors and
removed `VisibleForTesting`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
