jon-wei commented on a change in pull request #9373: Fix join filter push down
post-join virtual column handling
URL: https://github.com/apache/druid/pull/9373#discussion_r381552230
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
##########
@@ -297,6 +302,22 @@ public boolean isEnableFilterPushDown()
return enableFilterPushDown;
}
+ @VisibleForTesting
+ public Set<String>
getAdapterBaseColumnNamesWithVirtualColumns(VirtualColumns virtualColumns)
+ {
+ final Set<String> baseColumns = new HashSet<>();
+ Iterables.addAll(baseColumns, baseAdapter.getAvailableDimensions());
+ Iterables.addAll(baseColumns, baseAdapter.getAvailableMetrics());
+
+ for (VirtualColumn virtualColumn : virtualColumns.getVirtualColumns()) {
+ if (baseColumns.containsAll(virtualColumn.requiredColumns())) {
Review comment:
I initially wanted it to provide different functionality (where the
non-testing version also adds virtual columns to the prejoin/postjoin lists),
but I collapsed them into one method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
