suneet-s commented on a change in pull request #9373: Fix join filter push down
post-join virtual column handling
URL: https://github.com/apache/druid/pull/9373#discussion_r381443071
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
##########
@@ -538,18 +562,18 @@ private static void getCorrelationForRHSColumn(
// We push down if the function only requires base table columns
Expr.BindingDetails bindingDetails = lhsExpr.analyzeInputs();
Set<String> requiredBindings = bindingDetails.getRequiredBindings();
- if (!requiredBindings.stream().allMatch(requiredBinding ->
adapter.isBaseColumn(requiredBinding))) {
+ if (!requiredBindings.stream().allMatch(requiredBinding ->
baseColumnNames.contains(requiredBinding))) {
Review comment:
```suggestion
if (!baseColumnNames.containsAll(requiredBindings)) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
