suneet-s commented on a change in pull request #9373: Fix join filter push down post-join virtual column handling URL: https://github.com/apache/druid/pull/9373#discussion_r381439414
########## File path: processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java ########## @@ -72,8 +72,21 @@ private static final String PUSH_DOWN_VIRTUAL_COLUMN_NAME_BASE = "JOIN-FILTER-PUSHDOWN-VIRTUAL-COLUMN-"; private static final ColumnSelectorFactory ALL_NULL_COLUMN_SELECTOR_FACTORY = new AllNullColumnSelectorFactory(); + /** + * Analyze a filter and return a JoinFilterSplit indicating what parts of the filter should be applied pre-join + * and post-join. + * + * @param hashJoinSegmentStorageAdapter The storage adapter that is being queried + * @param baseColumnNames Set of names of columns that belong to the base table, + * including pre-join virtual columns + * @param originalFilter Original filter from the query + * @param enableFilterPushDown Whether to enable filter push down + * @return A JoinFilterSplit indicating what parts of the filter should be applied pre-join + * and post-join. + */ Review comment: 👍 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
