himanshug opened a new pull request #9507: optionally disable all of hardcoded zookeeper use URL: https://github.com/apache/druid/pull/9507 Paving Path Towards #9053 ### Description This patch adds a new configuration property `druid.zk.service.enabled=true/false, default = true` on all nodes to disable all of zookeeper activities that get setup even if user chooses to use HTTP based segment and task management. Some of those are.... - historical announcing itself as data server in zk - historicals watching zk for segment load/drop requests - historicals announcing segments in zk - middle managers watching zk for task assignment requests - middle managers doing task status updates in zk (above set of things are required, so that curator based task/segment management continues to work in rolling deployment scenario and also could be interchanged with http based task/segment management at any time) - HttpRemoteTaskRunner periodically doing cleanup of tasks from zk because MiddleManager continues to update the status in zk - external discovery announcements done via `ServiceAnnouncer` to keep tranquility working This property is undocumented for now till k8s based discovery extension PR shows up, that will have all the necessary documentation including setting `druid.zk.service.enabled=false` . <hr> This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [x] been tested in a test Druid cluster. <hr> ##### Key changed/added classes in this PR * `CliXXX` * `XXXModule` * And few others that directly/indirectly depended on `CuratorFramework`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
