clintropolis commented on a change in pull request #9507: optionally disable
all of hardcoded zookeeper use
URL: https://github.com/apache/druid/pull/9507#discussion_r396914173
##########
File path:
server/src/main/java/org/apache/druid/server/coordination/BatchDataSegmentAnnouncer.java
##########
@@ -99,13 +107,28 @@ public BatchDataSegmentAnnouncer(
return rv;
};
- if (this.config.isSkipSegmentAnnouncementOnZk()) {
+ isSkipSegmentAnnouncementOnZk = !zkEnablementConfig.isEnabled() ||
config.isSkipSegmentAnnouncementOnZk();
Review comment:
It seems like this class is almost entirely to handle zk stuff, does it need
to be bound and exist at all if zk is disabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
