clintropolis commented on a change in pull request #9507: optionally disable
all of hardcoded zookeeper use
URL: https://github.com/apache/druid/pull/9507#discussion_r396910915
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/LoadQueueTaskMaster.java
##########
@@ -67,7 +68,7 @@ public LoadQueuePeon giveMePeon(ImmutableDruidServer server)
return new HttpLoadQueuePeon(server.getURL(), jsonMapper, httpClient,
config, peonExec, callbackExec);
} else {
return new CuratorLoadQueuePeon(
- curator,
+ curatorFrameworkProvider.get(),
Review comment:
Just thinking out loud, doesn't need to be addressed in this PR, it seems
like maybe `LoadQueueTaskMaster` maybe needs some sort of peon factory that is
set by config so that it doesn't have to care about individual implementations
or curators and the like
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
