himanshug commented on issue #9507: optionally disable all of hardcoded zookeeper use URL: https://github.com/apache/druid/pull/9507#issuecomment-603022760 @clintropolis Your concern is legit, I am not sure if you have seen https://groups.google.com/forum/#!msg/druid-development/tWnwPyL0Vk4/2uLwqgQiAAAJ and https://groups.google.com/forum/#!msg/druid-development/eIWDPfhpM_U/AzMRxSQGAgAJ , but please take a look at those. That will explain that extensible "discovery" to be implemented in extensions is "node/service discovery" and "leader election". Other zookeeper usage for segment/task management should be totally replaced by `HTTP` counterparts which I have been using since long time. All the disabling of non-extensible use of zookeeper introduced in this PR can be removed if/when we can delete zookeeper based segment/task management. I hope with kubernetes discovery extension `HTTP` based segment/task management will get more adoption (as zookeeper based counterparts wouldn't work in that setting) and will eventually be deleted and so would all of the optionality introduced in this PR. `druid.discovery.type=zk` does exist, it is `druid.discovery.type=curator` and is default which leads to usage of curator based discovery abstractions impl `CuratorDruidLeaderSelector`, `CurationDruidNodeAnnouncer` and `CuratorDruidNodeDiscoveryProvider`. Next PR in this chain would have kubernetes based impl for all those i.e. `K8sDruidLeaderSelector`, `K8sDruidNodeAnnouncer` and `K8sDruidNodeDiscoveryProvider`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
