clintropolis commented on a change in pull request #9507: optionally disable
all of hardcoded zookeeper use
URL: https://github.com/apache/druid/pull/9507#discussion_r396909849
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java
##########
@@ -63,15 +63,20 @@
@Override
public void configure(Binder binder)
{
+ JsonConfigProvider.bind(binder, CURATOR_CONFIG_PREFIX,
ZkEnablementConfig.class);
JsonConfigProvider.bind(binder, CURATOR_CONFIG_PREFIX,
CuratorConfig.class);
JsonConfigProvider.bind(binder, EXHIBITOR_CONFIG_PREFIX,
ExhibitorConfig.class);
}
@Provides
@LazySingleton
@SuppressForbidden(reason = "System#err")
- public CuratorFramework makeCurator(CuratorConfig config, EnsembleProvider
ensembleProvider, Lifecycle lifecycle)
+ public CuratorFramework makeCurator(ZkEnablementConfig zkEnablementConfig,
CuratorConfig config, EnsembleProvider ensembleProvider, Lifecycle lifecycle)
Review comment:
I haven't looked too closely yet, but I wonder if this would be better if
this was marked as `@Nullable` and returned null instead of throwing the
runtime exception, and shift the burden of validating that curator is available
to the settings that do require it, such as inventory, segment loading, and
task management? The other stuff might be able to be simplified a bit and not
have to care about having the setting, and could probably avoid having some of
the signature changes to use providers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
