gianm commented on a change in pull request #10247:
URL: https://github.com/apache/druid/pull/10247#discussion_r553768375
##########
File path:
processing/src/test/java/org/apache/druid/segment/data/V3CompressedVSizeColumnarMultiIntsSerializerTest.java
##########
@@ -322,7 +322,7 @@ private void checkV2SerializedSizeAndData(int
offsetChunkFactor, int valueChunkF
Assert.assertEquals(subVals.get(j), vals.get(i)[j]);
}
}
- CloseQuietly.close(columnarMultiInts);
+ CloseableUtils.closeAndWrapExceptions(columnarMultiInts);
Review comment:
I put them both in a single `CloseableUtils.closeAll`
##########
File path:
processing/src/test/java/org/apache/druid/segment/data/V3CompressedVSizeColumnarMultiIntsSerializerTest.java
##########
@@ -395,7 +395,7 @@ private void generateV2SerializedSizeAndData(long numRows,
int maxValue, int max
Assert.assertEquals(subVals.get(j), expected[j]);
}
}
- CloseQuietly.close(columnarMultiInts);
+ CloseableUtils.closeAndWrapExceptions(columnarMultiInts);
Review comment:
Same solution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]