gianm commented on a change in pull request #10247:
URL: https://github.com/apache/druid/pull/10247#discussion_r553772142
##########
File path:
processing/src/main/java/org/apache/druid/segment/data/BlockLayoutColumnarDoublesSupplier.java
##########
@@ -168,7 +168,7 @@ public void get(final double[] out, final int[] indexes,
final int length)
protected void loadBuffer(int bufferNum)
{
- CloseQuietly.close(holder);
+ CloseableUtils.closeAndWrapExceptions(holder);
Review comment:
I didn't realize it didn't throw `IOException`. So actually, I could
just remove the CloseableUtils call completely here, and replace it with
`holder.close()`. I'll do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
