gianm commented on a change in pull request #10247:
URL: https://github.com/apache/druid/pull/10247#discussion_r553768704
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegment.java
##########
@@ -122,15 +122,14 @@ public void close() throws IOException
}).orElse(true);
}
if (acquireFailed) {
- CloseQuietly.close(closer);
+ CloseableUtils.closeAndWrapExceptions(closer);
return Optional.empty();
} else {
return Optional.of(closer);
}
}
- catch (Exception ex) {
- CloseQuietly.close(closer);
- return Optional.empty();
Review comment:
Good point, changed this to suppress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
