gianm commented on a change in pull request #10247:
URL: https://github.com/apache/druid/pull/10247#discussion_r553772787
##########
File path:
processing/src/main/java/org/apache/druid/segment/data/GenericIndexed.java
##########
@@ -530,13 +530,13 @@ public void close()
headerOut.writeInt(Ints.checkedCast(valuesOut.size()));
if (prevVal instanceof Closeable) {
- CloseQuietly.close((Closeable) prevVal);
+ CloseableUtils.closeAndWrapExceptions((Closeable) prevVal);
Review comment:
If it's ok with you, I'd prefer to leave it in for this patch, because I
didn't want to go through and make sure it's always ok to skip closing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
