gianm commented on a change in pull request #10247:
URL: https://github.com/apache/druid/pull/10247#discussion_r553771195
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
##########
@@ -329,9 +329,8 @@ public boolean doMergeResults(final GroupByQuery query)
finalResultSupplier
);
}
- catch (Exception ex) {
- CloseQuietly.close(resultSupplier);
- throw ex;
+ catch (Throwable e) {
Review comment:
Now that I think about it more, I guess the reason is that we always
want to close stuff, even if some weird Throwable got thrown. It's making it
behave like a finally or like a try-with-resources. I changed it back to
Throwable. Let me know if you disagree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
