capistrant commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r601884079
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java
##########
@@ -1447,6 +1452,7 @@ private void assertIngestionSchema(
null,
null,
null,
+ null,
null
Review comment:
I think we might. I don't think I was writing this with the intention of
having compaction tasks support this. It really wouldn't add value since
compaction isn't materially changing the underlying data. But I guess since
compaction is spinning up a parallel indexing task, we kinda need to consider
it so I will have to check on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
