capistrant commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r601882087
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -1066,7 +1075,8 @@ private synchronized void persistSequences() throws
IOException
ingestionState,
getTaskCompletionUnparseableEvents(),
getTaskCompletionRowStats(),
- errorMsg
+ errorMsg,
+ errorMsg == null
Review comment:
yes, it is saying that a successful streaming task means segments were
confirmed to be handed off. an unsuccessful task means we are not positive that
segments were handed off. I'm unsure if it is possible to have a streaming task
confirm that segments are handed off and still fail, but I assume it is not
very common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
