paul-rogers commented on code in PR #12845:
URL: https://github.com/apache/druid/pull/12845#discussion_r935990516
##########
sql/src/main/java/org/apache/druid/sql/SqlQueryPlus.java:
##########
@@ -66,6 +66,25 @@ public SqlQueryPlus(final String sql, final
AuthenticationResult authResult)
this(sql, (QueryContext) null, null, authResult);
}
+ public SqlQueryPlus(
Review Comment:
Four parameters is on the border: not so many that a builder is clearly
necessary, but, on the other hand, there is enough variation in parameter
formats that a builder might be handy.
Went ahead and added the builder. The result does seem to be a bit simpler,
so thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
