LakshSingla commented on code in PR #12845: URL: https://github.com/apache/druid/pull/12845#discussion_r936577696
########## sql/src/main/java/org/apache/druid/sql/DirectStatement.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql; + +import org.apache.druid.java.util.common.StringUtils; +import org.apache.druid.java.util.common.guava.Sequence; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.query.QueryInterruptedException; +import org.apache.druid.sql.SqlLifecycleManager.Cancellable; +import org.apache.druid.sql.calcite.planner.DruidPlanner; +import org.apache.druid.sql.calcite.planner.PlannerResult; +import org.apache.druid.sql.calcite.planner.PrepareResult; + +import java.util.concurrent.CopyOnWriteArrayList; + +/** + * Lifecycle for direct SQL statement execution, which means that the query + * is planned and executed in a single step, with no "prepare" step. + * Callers need call only: + * <ul> + * <li>{@link #execute()} to execute the query. The caller must close + * the returned {@code Sequence}.</li> + * <li>{@link #close()} to report metrics, or {@link #closeQuietly()} + * otherwise.</li> + * </ul> + * <p> + * The {@link #cancel()} method may be called from any thread and cancels + * the query. + * <p> + * All other methods are optional and are generally for introspection. + * <p> + * The class supports two threading models. In the simple case, the same + * thread creates this object and executes the query. In the split model, + * a request thread creates this object and plans the query. A separate + * response thread consumes results and performs any desired logging, etc. + * The object is transferred between threads, with no overlapping access. Review Comment: Thanks for the explanation. IMO there shouldn't be corner cases with this "sequential" manner in which Statements are accessed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
