gianm commented on code in PR #12845: URL: https://github.com/apache/druid/pull/12845#discussion_r940485028
########## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidTypeSystem.java: ########## @@ -29,7 +29,8 @@ public class DruidTypeSystem implements RelDataTypeSystem public static final DruidTypeSystem INSTANCE = new DruidTypeSystem(); /** - * Druid uses millisecond precision for timestamps internally. This is also the default at the SQL layer. + * Druid uses millisecond precision for timestamps internally. This is also + * the default at the SQL layer. Review Comment: > I wonder, should we allow our code to be 120 characters, but encourage 80 for comments? Here's [a random reference](https://spin.atomicobject.com/2016/09/24/improving-web-typography/#:~:text=Takeaway%3A%20Set%20text%20column%20widths,around%2075%20characters%20helps%20readability.) which suggests I'm not alone in this opinion. Yeah I guess the issue is that shorter lines lead to "taller" code, and displays are generally wider than they are tall. My feeling is that we need not be authoritarian: the only standard we need across the codebase is that line length for new code should be somewhere between 80 and 120 chars. I wouldn't have said anything here if this was a new comment. I only mentioned it because I didn't think there was a reason to change the pre-existing formatting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
