gianm commented on code in PR #12845:
URL: https://github.com/apache/druid/pull/12845#discussion_r940487974
##########
sql/src/main/java/org/apache/druid/sql/AbstractStatement.java:
##########
@@ -165,12 +180,12 @@ protected PlannerResult plan(DruidPlanner planner)
*/
public Set<ResourceAction> resources()
{
- return queryResource;
+ return cancelationResourceActions;
Review Comment:
cancellation (it's the only form with two Ls according to the most-specific
American English technical style guide I could find:
https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/cancel-canceled-canceling-cancellation;
and a variety of dictionaries including MW.)
##########
processing/src/main/java/org/apache/druid/query/QueryInterruptedException.java:
##########
@@ -44,7 +44,7 @@
public class QueryInterruptedException extends QueryException
{
public static final String QUERY_INTERRUPTED = "Query interrupted";
- public static final String QUERY_CANCELLED = "Query cancelled";
+ public static final String QUERY_CANCELED = "Query cancelled";
Review Comment:
Too bad the "cancelled" spelling is a documented error code. Echoes of the
HTTP "Referer" header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
