tejaswini-imply commented on code in PR #12852:
URL: https://github.com/apache/druid/pull/12852#discussion_r942325805
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/InputSourceSplitParallelIndexTaskRunner.java:
##########
@@ -86,13 +83,8 @@ final SubTaskSpec<T> newTaskSpec(InputSplit split)
{
final FirehoseFactory firehoseFactory;
final InputSource inputSource;
- if (baseInputSource instanceof FirehoseFactoryToInputSourceAdaptor) {
- firehoseFactory = ((FirehoseFactoryToInputSourceAdaptor)
baseInputSource).getFirehoseFactory().withSplit(split);
- inputSource = null;
- } else {
- firehoseFactory = null;
- inputSource = baseInputSource.withSplit(split);
- }
+ firehoseFactory = null;
+ inputSource = baseInputSource.withSplit(split);
Review Comment:
As mentioned in the other comment `baseInputSource` can't be an instance of
adapter input source since it's generated by
`IndexTask.IndexIOConfig.getNonNullInputSource()` from `InputRowParser` &
`FiniteFirehoseFactory` previously in case `InputSource` is null, now that
`FiniteFirehoseFactory` is removed user has to submit non-null input source for
batch index tasks for all the cases where `FiniteFirehoseFactory` instantiating
spec was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
