tejaswini-imply commented on code in PR #12852:
URL: https://github.com/apache/druid/pull/12852#discussion_r942306698
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexIngestionSpec.java:
##########
@@ -45,9 +44,7 @@ public ParallelIndexIngestionSpec(
super(dataSchema, ioConfig, tuningConfig);
if (dataSchema.getParserMap() != null && ioConfig.getInputSource() !=
null) {
- if (!(ioConfig.getInputSource() instanceof
FirehoseFactoryToInputSourceAdaptor)) {
- throw new IAE("Cannot use parser and inputSource together. Try using
inputFormat instead of parser.");
- }
+ throw new IAE("Cannot use parser and inputSource together. Try using
inputFormat instead of parser.");
Review Comment:
input source here can't be an instance of adapter input source since the
user can't create it directly, and it's generated by
`IndexTask.IndexIOConfig.getNonNullInputSource()` from `InputRowParser` &
`FiniteFirehoseFactory` previously in case `InputSource` is null, now that
`FiniteFirehoseFactory` is removed user has to submit non-null input source for
batch index tasks for all the cases where FiniteFirehoseFactory instantiating
spec was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
