tejaswini-imply commented on code in PR #12852:
URL: https://github.com/apache/druid/pull/12852#discussion_r942317118
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -1196,16 +1190,9 @@ public InputFormat getInputFormat()
return inputFormat;
}
- public InputSource getNonNullInputSource(@Nullable InputRowParser
inputRowParser)
+ public InputSource getNonNullInputSource()
Review Comment:
This might not be needed since, from what I observed either we can mention
`ioConfig#firehoseFactory + dataSchema#parser` or `ioConfig#inputSource +
ioConfig#inputFormat` combination in the ingestion spec, now that
FiniteFirehoseFactory is removed user has to shift to using
`ioConfig#inputSource + ioConfig#inputFormat`. In the case of
`SeekableStreamSamplerSpec`, adapters have to be used since users can submit
either `ioConfig#inputFormat` or `dataSchema#parser`, and `FirehoseFactory` or
`InputSource` isn't submitted in `SeekableStreamIndexTaskIOConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
