clintropolis commented on code in PR #12852:
URL: https://github.com/apache/druid/pull/12852#discussion_r944098743
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/RemoteTaskRunnerTest.java:
##########
@@ -816,7 +816,7 @@ public void testBlacklistZKWorkers() throws Exception
makeRemoteTaskRunner(rtrConfig);
- TestRealtimeTask task1 = new TestRealtimeTask(
+ TestIndexTask task1 = new TestIndexTask(
"realtime1",
Review Comment:
super nit-picky, but these task ids are kind of funny since they are no
longer realtime tasks
##########
server/src/main/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseFactory.java:
##########
@@ -79,6 +79,7 @@
* Builds firehoses that accept events through the {@link EventReceiver}
interface. Can also register these
* firehoses with an {@link ServiceAnnouncingChatHandlerProvider}.
*/
+@Deprecated
Review Comment:
I think `TimedShutoffFirehoseFactory` and `ClippedFirehoseFactory` need
marked deprecated too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
