tejaswini-imply commented on code in PR #12852:
URL: https://github.com/apache/druid/pull/12852#discussion_r944144957
##########
server/src/main/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseFactory.java:
##########
@@ -79,6 +79,7 @@
* Builds firehoses that accept events through the {@link EventReceiver}
interface. Can also register these
* firehoses with an {@link ServiceAnnouncingChatHandlerProvider}.
*/
+@Deprecated
Review Comment:
Just wanted to know, since `FirehoseFactory` is marked deprecated, does it
imply the implementations are deprecated as well? In that case, me marking
`EventReceiverFirehoseFactory` as deprecated already is redundant and will
remove it, in otherwise scenario I'll mark all 4 deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
