AmatyaAvadhanula commented on code in PR #13238:
URL: https://github.com/apache/druid/pull/13238#discussion_r1005247095
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java:
##########
@@ -65,27 +63,6 @@ public TaskRealtimeMetricsMonitor(
previousRowIngestionMetersTotals = new RowIngestionMetersTotals(0, 0, 0,
0);
}
- @Override
- public void start()
- {
- super.start();
- lastRoundMetricsToBePushed = true;
- }
-
- @Override
- public boolean monitor(ServiceEmitter emitter)
Review Comment:
The last round of metrics emission seems to be relevant only in the cases of
RealtimeMetricsMonitor and TaskRealtimeMetricsMonitor, where the new method is
being called
##########
server/src/main/java/org/apache/druid/segment/realtime/FireDepartmentMetrics.java:
##########
@@ -29,6 +29,8 @@
{
private static final long DEFAULT_PROCESSING_COMPLETION_TIME = -1L;
+ private static final long INVALID_SEGMENT_HANDOFF_TIME = -1L;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
