AmatyaAvadhanula commented on code in PR #13238:
URL: https://github.com/apache/druid/pull/13238#discussion_r1005246187


##########
core/src/main/java/org/apache/druid/java/util/metrics/ParametrizedUriEmitterMonitor.java:
##########
@@ -65,6 +65,13 @@ public void stop()
     super.stop();
   }
 
+  @Override
+  public void stopAfterLastRoundOfMetricsEmission(ServiceEmitter emitter)
+  {
+    monitors.values().forEach(monitor -> 
monitor.stopAfterLastRoundOfMetricsEmission(emitter));

Review Comment:
   Thanks for pointing this out. I think it may be needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to