clintropolis commented on code in PR #14014: URL: https://github.com/apache/druid/pull/14014#discussion_r1156574505
########## processing/src/main/java/org/apache/druid/segment/column/CachingStringDictionaryEncodedColumn.java: ########## @@ -54,7 +54,7 @@ /** * */ -public class StringDictionaryEncodedColumn implements DictionaryEncodedColumn<String> +public class CachingStringDictionaryEncodedColumn implements DictionaryEncodedColumn<String> Review Comment: oops, I was frustrated that I couldn't re-use it for my optimized nested scalar string column because it requires a `CachingIndexed<String>` which itself requires a `GenericIndexed<String>`, and all I have is either a `GenericIndexed<ByteBufffer>` or a `FrontCodedIndexed` depending on string encoding config Will change the name back -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
