imply-cheddar commented on code in PR #14014:
URL: https://github.com/apache/druid/pull/14014#discussion_r1156710158
##########
processing/src/main/java/org/apache/druid/segment/AutoTypeColumnMerger.java:
##########
@@ -120,11 +120,11 @@ public void
writeMergedValueDictionary(List<IndexableAdapter> adapters) throws I
adapter.getNestedColumnMergeables(name)
);
final SortedValueDictionary dimValues = mergable.getValueDictionary();
- mergable.mergeFieldsInto(mergedFields);
boolean allNulls = dimValues == null || dimValues.allNull();
sortedLookup = dimValues;
if (!allNulls) {
+ mergable.mergeFieldsInto(mergedFields);
Review Comment:
Just double checking, I had been thinking this was correct outside of the
`if` statement because, even if it's all nulls, the others might have never
seen a null and so you want to merge it so that null is properly registered.
Is that not a concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
