clintropolis commented on code in PR #14014:
URL: https://github.com/apache/druid/pull/14014#discussion_r1156721858
##########
processing/src/main/java/org/apache/druid/segment/AutoTypeColumnMerger.java:
##########
@@ -120,11 +120,11 @@ public void
writeMergedValueDictionary(List<IndexableAdapter> adapters) throws I
adapter.getNestedColumnMergeables(name)
);
final SortedValueDictionary dimValues = mergable.getValueDictionary();
- mergable.mergeFieldsInto(mergedFields);
boolean allNulls = dimValues == null || dimValues.allNull();
sortedLookup = dimValues;
if (!allNulls) {
+ mergable.mergeFieldsInto(mergedFields);
Review Comment:
i realized that if it is all null this isn't doing anything useful anyway so
i put it inside the if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
