clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1260792265
##########
extensions-contrib/tdigestsketch/src/test/java/org/apache/druid/query/aggregation/tdigestsketch/sql/TDigestSketchSqlAggregatorTest.java:
##########
@@ -444,7 +443,11 @@ public void testEmptyTimeseriesResults()
Druids.newTimeseriesQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
.intervals(new
MultipleIntervalSegmentSpec(ImmutableList.of(Filtration.eternity())))
- .filters(bound("dim2", "0", "0", false, false, null,
StringComparators.NUMERIC))
+ .filters(
+ NullHandling.replaceWithDefault()
+ ? numericSelector("dim2", "0", null)
+ : equality("dim2", 0L, ColumnType.LONG)
+ )
Review Comment:
`numericSelector` is actually a bound filter, but there are _also_ selector
filters that have number arguments, so I couldn't figure out how to
consistently make the static method do the right thing. Whether or not a filter
ends up as a numericSelector or regular selector in the classic mode depends on
whether or not the column type is numeric (if numeric, it becomes a regular
selector, if the column is a string, it stays as a bound filter with both
values equal).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
